#3: Added release code build #5

tomuben · 2022-05-04T17:55:20Z

New commands

generate_release_buildspec => Creates the AWS Codebuild release buildspec
deploy_release_build => Deploys the AWS Cloudformation stack for the release build of the project
validate_release_build => Validates the AWS Cloudformation template for the release build of the project
start_release_build => Triggers release build
start_test_release_build => Triggers a test release build

Other changes

The parameter aws-profile has been changed from required to optional. In GH actions the default AWS profile will be used (defined by the environment variables).

exasol_script_languages_container_ci_setup/lib/run_start_release_build.py

Get the stack resource and find the codebuild in the stack.

…n Github itself.

tkilias

See comments

And, I don't understand the build container arrow in the flow picture

exasol_script_languages_container_ci_setup/cli/commands/start_test_release_build.py

exasol_script_languages_container_ci_setup/lib/aws_access.py

exasol_script_languages_container_ci_setup/lib/github_release_creator.py

exasol_script_languages_container_ci_setup/lib/run_start_release_build.py

exasol_script_languages_container_ci_setup/templates/release_build_buildspec.yaml

user_guide/user_guide.md

Nicoretti

I like the overview picture :D

exasol_script_languages_container_ci_setup/lib/aws_access.py

exasol_script_languages_container_ci_setup/lib/generate_buildspec_common.py

exasol_script_languages_container_ci_setup/lib/run_start_release_build.py

Nicoretti · 2022-05-09T07:20:09Z

exasol_script_languages_container_ci_setup/lib/run_start_release_build.py

+        raise RuntimeError(f"Multiple projects match {project}. Found following matches: {matching_project}")
+    dry_run_value = "--dry-run"
+
+    gh_token = os.getenv("GITHUB_TOKEN")


wouldn't it make more sense to pass the token?

the token is a credential

Same as above

exasol_script_languages_container_ci_setup/lib/github_release_creator.py

exasol_script_languages_container_ci_setup/templates/release_build_buildspec.yaml

user_guide/release-flow.drawio

user_guide/test-release-flow.drawio

exasol_script_languages_container_ci_setup/templates/buildspec_batch_entry.yaml

2. Renamed GithubReleaseCreator => GithubDraftReleaseCreator 3. Add missing link to test-release-flow.png in user_guide.md

#3: Added release code build

77a60e4

tomuben temporarily deployed to AWS May 4, 2022 17:55 Inactive

Added unit test for start_release_build

3a6ef95

tomuben temporarily deployed to AWS May 4, 2022 18:20 Inactive

Fixed import of new commands

7d47479

tomuben temporarily deployed to AWS May 4, 2022 18:27 Inactive

Fix template for release build

a53a9cd

tomuben temporarily deployed to AWS May 4, 2022 18:44 Inactive

Fixed default output path for release buildspecs

e94b347

tomuben temporarily deployed to AWS May 5, 2022 09:42 Inactive

tomuben added 4 commits May 5, 2022 06:44

Added generate-release-buildspecs to import list

cf53a0f

Added start_release_build to import list

8891100

Added build_status to exception

9a91a1a

Fix match name of release CodeBuild

37783c5

tomuben had a problem deploying to AWS May 5, 2022 11:27 Failure

tomuben commented May 5, 2022

View reviewed changes

exasol_script_languages_container_ci_setup/lib/run_start_release_build.py Outdated Show resolved Hide resolved

Changed logic for getting release code build:

8ec6071

Get the stack resource and find the codebuild in the stack.

tomuben temporarily deployed to AWS May 5, 2022 12:36 Inactive

Changed comparison

e2c8f41

tomuben temporarily deployed to AWS May 5, 2022 12:39 Inactive

tomuben added 2 commits May 5, 2022 10:27

Check for timeout

2d2e859

Splitted release-build into version for release and release-test

8855a27

tomuben temporarily deployed to AWS May 5, 2022 18:31 Inactive

Made cmd line parameter aws_profile optional

e240b4d

tomuben temporarily deployed to AWS May 5, 2022 18:45 Inactive

Command start_test_release_build now creates the test draft release o…

7f48824

…n Github itself.

tomuben temporarily deployed to AWS May 6, 2022 14:24 Inactive

Added start_test_release_build to import

d3391a2

tomuben temporarily deployed to AWS May 6, 2022 14:31 Inactive

Fixed start_test_release_build t

c0d8cb9

Fix bug in generate_buildspec_common.py

20cde9d

tomuben temporarily deployed to AWS May 6, 2022 15:44 Inactive

Added some additional info

77bceb4

tomuben temporarily deployed to AWS May 6, 2022 18:11 Inactive

tkilias requested changes May 9, 2022

View reviewed changes

Nicoretti reviewed May 9, 2022

View reviewed changes

Changes from code review

03dfc8d

tomuben had a problem deploying to AWS May 12, 2022 17:03 Failure

tomuben mentioned this pull request May 12, 2022

#502 Moved ci to AWS code build exasol/script-languages#275

Merged

Updated dependency to script-languages-container-ci

2870623

tomuben temporarily deployed to AWS May 12, 2022 17:18 Inactive

Add trailing newline to buildspecs

9b07a22

tomuben temporarily deployed to AWS May 12, 2022 17:35 Inactive

Add trailing newline to buildspecs

83d3004

tomuben temporarily deployed to AWS May 12, 2022 17:42 Inactive

Add trailing newline to buildspecs

c02c1a2

tomuben temporarily deployed to AWS May 12, 2022 18:04 Inactive

Updated documentation for release and test-release flows.

3f78559

tomuben temporarily deployed to AWS May 12, 2022 18:30 Inactive

tkilias requested changes May 13, 2022

View reviewed changes

Nicoretti reviewed May 13, 2022

View reviewed changes

exasol_script_languages_container_ci_setup/templates/buildspec_batch_entry.yaml Show resolved Hide resolved

1. tiny changes in flow diagrams

404955a

2. Renamed GithubReleaseCreator => GithubDraftReleaseCreator 3. Add missing link to test-release-flow.png in user_guide.md

tomuben temporarily deployed to AWS May 13, 2022 10:23 Inactive

tkilias previously approved these changes May 13, 2022

View reviewed changes

Changed logic about how to pass GH Token to GithhubDraftReleaseCreator

832b589

tomuben dismissed tkilias’s stale review via 832b589 May 13, 2022 16:21

tomuben temporarily deployed to AWS May 13, 2022 16:21 Inactive

Nicoretti approved these changes May 16, 2022

View reviewed changes

tomuben merged commit 50ad5e6 into main May 16, 2022

tomuben deleted the feature/3_addess_release_code_build_and_command branch May 16, 2022 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3: Added release code build #5

#3: Added release code build #5

tomuben commented May 4, 2022 •

edited

Loading

tkilias left a comment

Nicoretti left a comment

Nicoretti May 9, 2022

tkilias May 11, 2022

tomuben May 12, 2022

#3: Added release code build #5

#3: Added release code build #5

Conversation

tomuben commented May 4, 2022 • edited Loading

New commands

Other changes

tkilias left a comment

Choose a reason for hiding this comment

Nicoretti left a comment

Choose a reason for hiding this comment

Nicoretti May 9, 2022

Choose a reason for hiding this comment

tkilias May 11, 2022

Choose a reason for hiding this comment

tomuben May 12, 2022

Choose a reason for hiding this comment

tomuben commented May 4, 2022 •

edited

Loading